Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@semaphore-protocol/data uses utility functions that can be replaced by @zk-kit/utils #773

Open
cedoor opened this issue May 7, 2024 · 2 comments
Open

@semaphore-protocol/data uses utility functions that can be replaced by @zk-kit/utils #773

cedoor opened this issue May 7, 2024 · 2 comments
Assignees
@jancris100
Labels
good first issue Good for newcomers refactoring ♻️ A code change that neither fixes a bug nor adds a feature
Milestone
Semaphore V4

Comments

@cedoor
Copy link
Member

cedoor commented May 7, 2024 •
edited by vplasencia

Description

@semaphore-protocol/data uses checkParameters to check if the parameter types are the correct ones. Since there's already a @zk-kit/utils dependency, it could use the zk-kit utility error-handlers functions directly, and avoid duplicating code.
@cedoor cedoor added refactoring ♻️ A code change that neither fixes a bug nor adds a feature good first issue Good for newcomers labels May 7, 2024
@cedoor cedoor added this to the Semaphore V4 milestone May 7, 2024
@jancris100
Copy link

Can you assign this to me please?

@vplasencia
Copy link
Member

Hey @jancris100 sure. I just assigned you this issue. Please, let us know if you have questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jancris100 jancris100

Labels
good first issue Good for newcomers refactoring ♻️ A code change that neither fixes a bug nor adds a feature
Projects
Semaphore Board
Status: 🏗 In Progress
Milestone
Semaphore V4
Development

No branches or pull requests
3 participants
@cedoor @vplasencia @jancris100